CBOR-to-JSON: fix integer overflow when computing allocation size#280
Merged
thiagomacieira merged 1 commit intointel:mainfrom Mar 14, 2025
Merged
Conversation
Use add_check_overflow and mul_check_overflow to ensure the arithmetic operations do not overflow when computing the size to allocate.
thiagomacieira
force-pushed
the
cbor-to-json-fix-int-overflow
branch
from
df7719d to
dc1b08c
Compare
Member
|
Thanks, much appreciated. As I said in #279, we probably should add testing of invalid rows in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
add_check_overflowandmul_check_overflowto ensure the arithmetic operations do not overflow when computing the size to allocate.