Closed
Conversation
The bool datatype was added in C99, so make a typedef for pre-C99 versions of C, and define true/false.
Merged
Comment on lines
+51
to
+57
| typedef int bool; | ||
| # ifndef true | ||
| # define true 1 | ||
| # endif | ||
| # ifndef false | ||
| # define false 0 | ||
| # endif |
Member
There was a problem hiding this comment.
This is correct, but such not a good idea in a public header.
I think we're just going ban C89 builds.
Member
|
Thank you for the effort, but no, I think we will reject. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bool datatype was added in C99,
so make a typedef for pre-C99 versions
of C, and define true/false.