Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds an advanced CodeQL scanning workflow and introduces a Dockerfile that builds a Python-based container preloaded with pytest and numerous mfd-* tools under a non-root user.
- Integrates a GitHub Actions CodeQL workflow (
.github/workflows/codeql.yml) supporting Python and Actions languages. - Creates a
Dockerfilebased onpython:3.13-slimto installmfd-*packages and configures a non-rootappuserwith/bin/bashas the entrypoint.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Dockerfile | New container setup, installs mfd-* tools and pytest, creates non-root user |
| .github/workflows/codeql.yml | Adds CodeQL workflow for security and quality analysis |
Comments suppressed due to low confidence (1)
Dockerfile:4
- Since
pip installruns as root before switching toappuser, ensure installed files have correct permissions or switch to the non-root user before installing to avoid permission issues.
RUN useradd --create-home appuser
Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
Signed-off-by: Baczek, Arkadiusz <arkadiusz.baczek@intel.com>
This pull request introduces two major changes: the addition of a CodeQL workflow for advanced code scanning and the creation of a new
Dockerfilefor building a Python-based container with pre-installed tools and libraries.Code Scanning Enhancements:
.github/workflows/codeql.yml: Added a CodeQL workflow to enable advanced code scanning for security and quality analysis. This workflow supports multiple languages, including Python and Actions, and provides options for customizing build modes and queries.Docker Container Setup:
Dockerfile: Created a new Dockerfile based onpython:3.13-slim. It installs various Python libraries and tools (e.g.,pytest,mfd-*packages) and sets up a non-root user (appuser) with/bin/bashas the default command.