Conversation
|
We don't publish DEVs .whl. |
1 similar comment
|
We don't publish DEVs .whl. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
We don't publish DEVs .whl. |
1 similar comment
|
We don't publish DEVs .whl. |
There was a problem hiding this comment.
Pull Request Overview
Initial commit introducing the SerialConnection module, tests, documentation scaffolding, and CI/CD setup.
- Implement core SerialConnection class with send, read, timed-read, and background-reading features.
- Add unit tests for basic reading and context-manager behavior.
- Establish Sphinx documentation, example script, and GitHub Actions workflows for build, test, and release.
Reviewed Changes
Copilot reviewed 26 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mfd_serial/serial.py | Core SerialConnection implementation |
| tests/unit/test_serial/test_serial.py | Unit tests covering read and context manager |
| README.md | Usage instructions and examples |
| sphinx-doc/index.rst | Documentation entry points |
| .github/workflows/build_upload_whl.yml | CI workflow for building and publishing wheel |
Comments suppressed due to low confidence (3)
README.md:21
- Method name in code is
send, notwrite. Update the docs to callserial.send('Text to send').
serial.write('Text to send')
README.md:41
- The class is named
SerialConnection, notSerialDriver. Update the text for consistency.
SerialDriver can be used as context manager:
mfd_serial/serial.py:45
- The
sendmethod is not covered by any unit tests. Consider adding a test that mocks the underlying serial port and verifies thatwriteis called with the correctly encoded message.
def send(self, msg: str) -> None:
Signed-off-by: Baczek, Arkadiusz <arkadiusz.baczek@intel.com>
|
We don't publish DEVs .whl. |
1 similar comment
|
We don't publish DEVs .whl. |
No description provided.