feat: Refactor VM object to inherit from Host#2
Open
KTokarze wants to merge 1 commit intointel:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the VM class to inherit from Host, enabling better code reuse and maintainability in the HyperV module. The changes override the Host factory pattern for VM instances while preserving VM-specific initialization logic.
- Introduces inheritance from
Hostclass with custom__new__method to bypass factory pattern - Updates constructor to call
super().__init__()with connection and additional kwargs - Fixes documentation typos and improves consistency in terminology
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
313ceb1 to
bca1583
Compare
Refactor VM object to inherit Host funcionalities, attributes and sub-objects. Signed-off-by: Kacper Tokarzewski <kacper.tokarzewski@intel.com>
bca1583 to
37c3e73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
VMclass inmfd_hyperv/instances/vm.pyto inherit from theHostclass, adjusts its initialization logic to bypass theHostfactory pattern, and makes several minor documentation and code improvements. The changes improve code reuse, maintainability, and clarity.Class inheritance and initialization refactor:
VMclass to inherit fromHostand overrode the__new__method to bypass theHostfactory pattern for VM instances. The constructor now callssuper().__init__, passing theconnectionand any additional keyword arguments. This enables better code reuse and integration with theHostclass while maintaining the specific instantiation logic required for VMs. [1] [2] [3]Documentation and readability improvements: