fix: accept alternate mirror profile success response#3
Open
sregister wants to merge 1 commit intointel:mainfrom
Open
fix: accept alternate mirror profile success response#3sregister wants to merge 1 commit intointel:mainfrom
sregister wants to merge 1 commit intointel:mainfrom
Conversation
On different IPU control-plane versions, adding a mirror profile can return different success messages; accept both known success outputs.
There was a problem hiding this comment.
Pull request overview
Updates the CliClient.create_mirror_profile success detection to handle multiple known “success” outputs returned by different IPU control-plane versions.
Changes:
- Accept either
"command succeeded"or"random mirror profile set"as success markers forcreate_mirror_profile. - Add unit tests covering the alternate success message and a failure message raising
CliClientException.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
mfd_cli_client/base.py |
Expands mirror profile success detection using a shared set of success markers. |
tests/unit/test_mfd_cli_client/test_base.py |
Adds tests for alternate success output and verifies failure output raises an exception. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@dhiraj3880 Can you take a look at this |
dhiraj3880
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On different IPU control-plane versions, adding a mirror profile can return different success messages; accept both known success outputs.