Skip to content

[UR] Update descriptions of *WithArgsExp() API#21425

Merged
kswiecicki merged 1 commit intointel:syclfrom
ldorau:Update_description_of_WithArgsExp_API
Mar 4, 2026
Merged

[UR] Update descriptions of *WithArgsExp() API#21425
kswiecicki merged 1 commit intointel:syclfrom
ldorau:Update_description_of_WithArgsExp_API

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Mar 3, 2026

No description provided.

@ldorau ldorau requested review from a team as code owners March 3, 2026 16:50
@ldorau ldorau requested a review from mmichel11 March 3, 2026 16:50
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small grammatical suggestions

--- #--------------------------------------------------------------------------
type: function
desc: "Append a kernel execution command to a command-buffer object with setting args at kernel launch."
desc: "Append a kernel execution command to a command-buffer object with setting args at kernel launch time."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc: "Append a kernel execution command to a command-buffer object with setting args at kernel launch time."
desc: "Append a kernel execution command to a command-buffer object and set args at kernel launch time."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

--- #--------------------------------------------------------------------------
type: function
desc: "Enqueue a command to execute a kernel"
desc: "Enqueue a command to execute a kernel with setting args at kernel launch time."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc: "Enqueue a command to execute a kernel with setting args at kernel launch time."
desc: "Enqueue a command to execute a kernel and set args at kernel launch time."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Done

@ldorau ldorau force-pushed the Update_description_of_WithArgsExp_API branch from 5cd23d3 to 253877c Compare March 4, 2026 07:31
@ldorau
Copy link
Contributor Author

ldorau commented Mar 4, 2026

Just small grammatical suggestions

@mmichel11 Thanks! Done

@ldorau ldorau requested a review from mmichel11 March 4, 2026 07:33
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau
Copy link
Contributor Author

ldorau commented Mar 4, 2026

CI jobs failing because of #21023 and #21439

@ldorau
Copy link
Contributor Author

ldorau commented Mar 4, 2026

Please review @intel/unified-runtime-reviewers @kswiecicki @KFilipek @pbalcer

@ldorau ldorau requested review from KFilipek and kswiecicki March 4, 2026 09:06
@ldorau
Copy link
Contributor Author

ldorau commented Mar 4, 2026

CI jobs failing because of #21023, #21439 and #20827

@kswiecicki kswiecicki merged commit c42de86 into intel:sycl Mar 4, 2026
57 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants