[UR] Update descriptions of *WithArgsExp() API#21425
Merged
kswiecicki merged 1 commit intointel:syclfrom Mar 4, 2026
Merged
Conversation
mmichel11
reviewed
Mar 3, 2026
Contributor
mmichel11
left a comment
There was a problem hiding this comment.
Just small grammatical suggestions
| --- #-------------------------------------------------------------------------- | ||
| type: function | ||
| desc: "Append a kernel execution command to a command-buffer object with setting args at kernel launch." | ||
| desc: "Append a kernel execution command to a command-buffer object with setting args at kernel launch time." |
Contributor
There was a problem hiding this comment.
Suggested change
| desc: "Append a kernel execution command to a command-buffer object with setting args at kernel launch time." | |
| desc: "Append a kernel execution command to a command-buffer object and set args at kernel launch time." |
| --- #-------------------------------------------------------------------------- | ||
| type: function | ||
| desc: "Enqueue a command to execute a kernel" | ||
| desc: "Enqueue a command to execute a kernel with setting args at kernel launch time." |
Contributor
There was a problem hiding this comment.
Suggested change
| desc: "Enqueue a command to execute a kernel with setting args at kernel launch time." | |
| desc: "Enqueue a command to execute a kernel and set args at kernel launch time." |
5cd23d3 to
253877c
Compare
Contributor
Author
@mmichel11 Thanks! Done |
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Contributor
Author
Contributor
Author
|
Please review @intel/unified-runtime-reviewers @kswiecicki @KFilipek @pbalcer |
kswiecicki
approved these changes
Mar 4, 2026
KFilipek
approved these changes
Mar 4, 2026
Contributor
Author
mmichel11
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.