fix(cold): track stream producer tasks for graceful shutdown#40
Open
fix(cold): track stream producer tasks for graceful shutdown#40
Conversation
Stream producers were spawned via bare `tokio::spawn`, escaping the task runner's `TaskTracker`. This meant they were not awaited during graceful shutdown and ran outside the read/write serialization barrier. Add a separate `stream_tracker` on `ColdStorageTaskInner` for long-lived stream producers. Streams are tracked for shutdown but not drained before writes — backends provide their own read isolation (MDBX snapshots, PostgreSQL REPEATABLE READ, anchor-hash detection). Strengthen `ColdStorage::produce_log_stream` docs to make the concurrency contract explicit. Closes ENG-1988 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokio::spawn, escaping the task runner'sTaskTracker— not awaited during shutdown, not visible to the read/write barrierstream_tracker: TaskTrackertoColdStorageTaskInnerfor long-lived stream producersColdStorage::produce_log_streamdocs to make the concurrency contract explicitCloses ENG-1988
Test plan
cargo clippy -p signet-cold --all-features --all-targetscargo clippy -p signet-cold --no-default-features --all-targetscargo +nightly fmtcargo t -p signet-cold— conformance suite passes🤖 Generated with Claude Code