chore: various updates to improve debugging apps by Fraser999 · Pull Request #123 · init4tech/bin-base

Fraser999 · 2026-02-28T01:59:02Z

This PR comprises several changes:

disables connection pooling in OAuth job to avoid stale connection errors, and reduces log level from error to warn for failing to refresh the OAuth token (as this is a non-critical error I believe)
avoids recording the current span twice (it's recorded as the last entry in "spans" since we enable with_span_list)
supports including file and line number in log lines by setting the env var TRACING_WITH_FILE_AND_LINE_NO to a non-empty value
a somewhat larger change to env var handling:
- the existing init4 function is now deprecated in favour of a similar init function which requires the tracing and metrics configs to be passed in. The idea is that callers will add these configs to their main config of their app, and hence all the env vars including the tracing and metrics ones will be visible via the inventory and checkable via the check_inventory methods
- added the tracing config, which internally holds an optional OTEL config
- updated check_inventory's error case to also include env vars which are set to an empty value
- added a set of types like OptionalBoolWithDefault which are designed to be used as members of config structs. These are provided with a const generic arg to be used as the default, allowing the config to not have to deal with Option<T> where the optional value is always set to Some after calling from_env.

Fraser999 · 2026-02-28T01:59:16Z

chore: various updates to improve debugging apps #123 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

dylanlott · 2026-03-04T23:13:52Z

src/perms/oauth.rs

+        let duration = tokio::time::Duration::from_secs(self.config.oauth_token_refresh_interval);
+        let mut interval = tokio::time::interval(duration);
+        interval.set_missed_tick_behavior(MissedTickBehavior::Delay);

        loop {
+            interval.tick().await;
            debug!("Refreshing oauth token");
            match self.authenticate().await {
-                Ok(_) => {
-                    debug!("Successfully refreshed oauth token");
-                }
-                Err(err) => {
-                    let mut current = &err as &dyn Error;
-
-                    // This is a little hacky, but the oauth library nests
-                    // errors quite deeply, so we need to walk the source chain
-                    // to get the full picture.
-                    let mut source_chain = Vec::new();
-                    while let Some(source) = current.source() {
-                        source_chain.push(source.to_string());
-                        current = source;
-                    }
-                    let source_chain = source_chain.join("\n\n Caused by: \n");
-
-                    error!(%err, %source_chain, "Failed to refresh oauth token");
-                }
+                Ok(_) => debug!("Successfully refreshed oauth token"),
+                Err(error) => warn!(
+                    error = %format!("{:#}", eyre!(error)),
+                    "Failed to refresh oauth token"
+                ),


This changes the behavior to wait before authenticating, but we want to maintain previous behavior, which is authenticate then wait. This ensures fast startups for anything gated by authentication.

The first tick is immediately ready, so there's no real change in behaviour here.

dylanlott · 2026-03-04T23:34:32Z

src/utils/from_env.rs

+optional_with_default! {
+    /// An optional boolean with a const default, for use in config structs.
+    /// A non-empty value is treated as `true`; missing or empty falls back to the default.
+    OptionalBoolWithDefault, bool, |env_var, _s| Ok(true)


This will treat "false" as true, no? That feels counterintuitive. Should handle these types of cases explicitly, e.g. "false" or "0" should actually set false, and then document each case.

Yes, but that matches the impl FromEnvVar for bool pretty much. The only difference is that for an unset env var OptionalBoolWithDefault::from_env_var will return Ok(default), whereas bool::from_env_var will return Err(NotPresent), and for e.g. TRACING_LOG_JSON, we currently unconditionally map errors to false. (I think it'd be better to only map NotPresent to the default value and pass through NotUnicode errors as OptionalBoolWithDefault does.

I agree that parsing "false" as true is counterintuitive, but it's also very common for env vars. Maybe we could provide a new type which does actual parsing of the env var so that:

truthy => true

falsy => false

unset/empty => default if provided, error if not

src/utils/from_env.rs

dylanlott · 2026-03-05T00:04:40Z

src/utils/from_env.rs

            Ok(_) => T::from_env_var(env_var).map(Some),
-            Err(_) => Ok(None),
+            Err(VarError::NotPresent) => Ok(None),
+            Err(error) => Err(FromEnvErr::parse_error(env_var, error)),


Technically a small behavior change but previous logic would swallow the other error, which would only be a NotUnicode error in this case, so I think that's okay for the use case at hand. Some callers might have to explicitly handle this slightly different.

Hmm - I can certainly revert this change, but I'm not sure I agree that it's the best approach. If a user set the env var to something, they probably expected it to be parsed. I think it's a potential footgun for users to silently treat that case as the same as not setting the env var at all.

dylanlott · 2026-03-05T00:24:12Z

examples/otlp-export.rs

+        TracingConfig::from_env().wrap_err("failed to get tracing config from environment")?;
+    let metrics_config =
+        MetricsConfig::from_env().wrap_err("failed to get metrics config from environment")?;
+    let _guard = init(tracing_config, metrics_config);


Will need to ticket out downstream upgrade work to accommodate this config change.

Sure - I can do that. I think the list is:

builder

filler

quincey

seal

tx-pool

I left the existing init4 function in place (although deprecated) to ease the transition.

dylanlott · 2026-03-05T00:25:33Z

examples/otlp-export.rs

-    signal_hook::flag::register(signal_hook::consts::SIGTERM, Arc::clone(&term))?;
-    signal_hook::flag::register(signal_hook::consts::SIGINT, Arc::clone(&term))?;
-
-    let _guard = init4();


@init4samwise can you list all of the downstream callers of this init4 function in init4tech repos?

prestwich · 2026-03-06T14:29:02Z

a somewhat larger change to env var handling:

one idea i have toyed with is making init4<T: ConfigTrait>() -> eyre::Result<T> with trait ConfigTrait: FromEnv + AsRef<TracingConfig> + AsRef<MetricsConfig>. that way we can be opinionated and still pretty simple

thoughts?

Fraser999 · 2026-03-06T15:57:17Z

that way we can be opinionated and still pretty simple

Yes, that seems like an improvement, in that the caller doesn't need to do two steps (parse config then call init4). I guess we'd need to make the return type a simple struct containing the parsed T and the OTEL guard.

I made that change in b9f9cad.

Fraser999 added 4 commits February 27, 2026 16:21

disable conn pooling in oauth job and reduce log level

6108fbd

avoid recording the current span twice

4950c2b

support including file and line number in log lines

db3e41a

update env var handling

f20eed0

Fraser999 marked this pull request as ready for review February 28, 2026 02:17

Fraser999 requested review from Evalir, dylanlott and prestwich February 28, 2026 02:17

Fraser999 changed the title ~~disable conn pooling in oauth job and reduce log level~~ chore: various updates to improve debugging apps Feb 28, 2026

Fraser999 mentioned this pull request Feb 28, 2026

chore: improve debugging/observability init4tech/builder#232

Draft

dylanlott requested changes Mar 5, 2026

View reviewed changes

add config trait

b9f9cad

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: various updates to improve debugging apps#123

chore: various updates to improve debugging apps#123
Fraser999 wants to merge 5 commits intomainfrom
fraser/eng-1943/various-updates

Fraser999 commented Feb 28, 2026 •

edited

Loading

Uh oh!

Fraser999 commented Feb 28, 2026

Uh oh!

dylanlott Mar 4, 2026

Uh oh!

Fraser999 Mar 6, 2026

Uh oh!

dylanlott Mar 4, 2026

Uh oh!

Fraser999 Mar 6, 2026

Uh oh!

Uh oh!

dylanlott Mar 5, 2026

Uh oh!

Fraser999 Mar 6, 2026

Uh oh!

dylanlott Mar 5, 2026

Uh oh!

Fraser999 Mar 6, 2026

Uh oh!

dylanlott Mar 5, 2026

Uh oh!

prestwich commented Mar 6, 2026

Uh oh!

Fraser999 commented Mar 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Fraser999 commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fraser999 commented Feb 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prestwich commented Mar 6, 2026

Uh oh!

Fraser999 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fraser999 commented Feb 28, 2026 •

edited

Loading

Fraser999 commented Mar 6, 2026 •

edited

Loading