Skip to content

Add a fallback for FFT when VkFFT is not found or broken#130

Merged
inducer merged 10 commits intoinducer:mainfrom
isuruf:loopy_fft
Aug 9, 2022
Merged

Add a fallback for FFT when VkFFT is not found or broken#130
inducer merged 10 commits intoinducer:mainfrom
isuruf:loopy_fft

Conversation

@isuruf
Copy link
Collaborator

@isuruf isuruf commented Aug 7, 2022

No description provided.

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This generally looks good. Some fairly minor things below.

Comment on lines 1170 to 1172
if (sys.platform == "darwin"
and queue.context.devices[0].platform.name
== "Portable Computing Language"):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given our experiments, we should probably narrow this to x86-only.

@inducer inducer merged commit 3d2a57a into inducer:main Aug 9, 2022
@inducer
Copy link
Owner

inducer commented Aug 9, 2022

Thanks!

@hirish99
Copy link
Contributor

@isuruf isuruf deleted the loopy_fft branch August 10, 2022 19:10
@isuruf
Copy link
Collaborator Author

isuruf commented Aug 11, 2022

Thanks @hirish99 for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants