Import and update BlockIndexRanges from sumpy#92
Merged
inducer merged 7 commits intoinducer:mainfrom Jun 12, 2021
Merged
Conversation
alexfikl
force-pushed
the
block-index-ranges
branch
from
7f99712 to
4ab9003
Compare
Owner
|
I'm assuming this is ready to un-draft, because otherwise thing would be left in a broken state. If not, stop me! :) |
Collaborator
Author
Yeah, should be good to go! Just needed inducer/sumpy#65. Thanks for finishing it up! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are removed from sumpy in inducer/sumpy#65.
This PR also reworks
BlockIndexRangesa bit. Before the indices and ranges werecl.array.Array, which resulted in a lot of back and forth (when skeletonizing in #30), so now they're justndarray. The arrays passed on to sumpy are still constructed ascl.array.Array.requirements.txtback to main sumpy.