Address remaining comments from #30#165
Merged
inducer merged 6 commits intoinducer:mainfrom Jul 7, 2022
Merged
Conversation
inducer
approved these changes
Jul 1, 2022
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks for following up! This actually makes a great big difference in how easy to follow I find that code. A few things below, good to go once those are addressed.
pytential/linalg/utils.py
Outdated
Comment on lines
373
to
374
| :arg ord: the type of the matrix norm used to compute errors, as described | ||
| in :func:`numpy.linalg.norm`. |
Owner
There was a problem hiding this comment.
State that this identifies the norm
Collaborator
Author
There was a problem hiding this comment.
alexfikl
force-pushed
the
ds-fixes
branch
2 times, most recently
from
0617bda to
2e89712
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds docs and comments and some types here and there following the review from #30.
There is one actual change:
LandRare changed from(nclusters, ncluster)object arrays to just(nclusters,)since they are block diagonal anyways. Not sure why I made them 2D arrays in the first place..