Merged
Conversation
alexfikl
commented
May 8, 2022
alexfikl
commented
May 8, 2022
inducer
reviewed
May 13, 2022
Owner
inducer
left a comment
There was a problem hiding this comment.
Thanks! Some comments from a quick scroll.
aab3e5b to
7a1a23f
Compare
inducer
reviewed
May 19, 2022
Owner
inducer
left a comment
There was a problem hiding this comment.
Thanks! A few more things below. LGTM once these are addressed.
Owner
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
a844660 to
aaf1db8
Compare
Owner
|
This looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rips out the mappers from #30 for some discussion + tests. The new mappers are
IntGTermCollector: removes all non-IntGterms in the expression and all non-constant coefficients.KernelTransformationRemover: removes transforms fromIntGkernels.DOFDescriptorReplacer: re-tags an expression.They're basically used to clean up a given expression for source->proxy or proxy->target evaluation, which
IntGterms, since those are only diagonal operators.TODO: