Skip to content

Add mappers for direct solver#152

Merged
inducer merged 3 commits intoinducer:mainfrom
alexfikl:ds-mappers
Jun 5, 2022
Merged

Add mappers for direct solver#152
inducer merged 3 commits intoinducer:mainfrom
alexfikl:ds-mappers

Conversation

@alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented May 8, 2022

This rips out the mappers from #30 for some discussion + tests. The new mappers are

  • IntGTermCollector: removes all non-IntG terms in the expression and all non-constant coefficients.
  • KernelTransformationRemover: removes transforms from IntG kernels.
  • DOFDescriptorReplacer: re-tags an expression.

They're basically used to clean up a given expression for source->proxy or proxy->target evaluation, which

  • doesn't need any non-IntG terms, since those are only diagonal operators.
  • doesn't need to see any source / target derivatives, but generally also can't use these because we don't want to compute normals and things at the proxy points.

TODO:

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments from a quick scroll.

@alexfikl alexfikl force-pushed the ds-mappers branch 4 times, most recently from aab3e5b to 7a1a23f Compare May 14, 2022 12:54
@alexfikl alexfikl requested a review from inducer May 15, 2022 02:27
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few more things below. LGTM once these are addressed.

@inducer
Copy link
Owner

inducer commented May 19, 2022

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

@inducer inducer merged commit 2450074 into inducer:main Jun 5, 2022
@inducer
Copy link
Owner

inducer commented Jun 5, 2022

This looks good, thanks!

@alexfikl alexfikl deleted the ds-mappers branch June 6, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants