Pass translation_classes_data to sumpy#102
Closed
isuruf wants to merge 4 commits intoinducer:mainfrom
Closed
Conversation
Owner
|
Marking draft and unsubscribing for CI fails, let me know (request review/@-mention) when ready. |
isuruf
force-pushed
the
translation_classes_data
branch
from
328937e to
7b717cf
Compare
isuruf
force-pushed
the
translation_classes_data
branch
from
7b717cf to
4a543da
Compare
Collaborator
Author
|
@inducer, this is ready. |
Merged
3 tasks
inducer
reviewed
May 9, 2022
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this. Two questions below.
Comment on lines
+606
to
+608
| from sumpy.fmm import SumpyTranslationClassesData | ||
| translation_classes_data = SumpyTranslationClassesData(actx.queue, | ||
| geo_data.traversal()) |
Owner
There was a problem hiding this comment.
This isn't a sumpy-specific interface. How come we're passing ostensibly sumpy-specific data?
| from sumpy.fmm import SumpyTranslationClassesData | ||
| translation_classes_data = SumpyTranslationClassesData(actx.queue, | ||
| geo_data.traversal()) | ||
| tree_indep = self._tree_indep_data_for_wrangler( |
Owner
There was a problem hiding this comment.
Would it make sense to compute the translation classes as part of the wrangler creation?
Collaborator
Author
There was a problem hiding this comment.
Wrangler doesn't have access to a queue. Should I add that?
Owner
There was a problem hiding this comment.
You can just make a private, temporary queue:
with cl.CommandQueue(ctx) as queue:
...
Collaborator
Author
|
Made redundant by inducer/sumpy#117 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this is passed to sumpy, it will use the optimized code path where the M2L matrix is precomputed.