Optimizations for DerivativeBinder#72
Merged
inducer merged 5 commits intoinducer:mainfrom Feb 11, 2022
Merged
Conversation
alexfikl
commented
Nov 15, 2021
1 task
2204799 to
324ada6
Compare
324ada6 to
2d65c32
Compare
2d65c32 to
be3ff28
Compare
be3ff28 to
415307f
Compare
415307f to
4cbb052
Compare
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits should be fairly self-contained. The changes are
tuple([...])overtuple(generator), since it's a bit faster and some of these get called a lot.geometric_algebra.mappers.DerivativeBinder.map_productif it didn't find any nablas.The only change that had a visible effect (i.e > 1s) was the second one. The main culprit was the hashing and equality comparisons for the various caches and that helped hit the
self is othercase more often and avoid the expensive checks.