Fix codegen for temporary variables declaration#738
Closed
kaushikcfd wants to merge 2 commits intomainfrom
Closed
Conversation
3 tasks
inducer
reviewed
Jan 19, 2023
Comment on lines
-909
to
+907
| tv.name in sub_knl_temps): | ||
| if tv.address_space != AddressSpace.GLOBAL: |
Owner
There was a problem hiding this comment.
Not loving this change, as it just dumps all temporaries in all subkernels no matter what, whether they're used or not. sub_knl_temps would be unused/pointless after this. Closing in favor of #741 (or a version of it).
Collaborator
Author
There was a problem hiding this comment.
The bounds of the loop had changed, but #741 is better as it fixes some more typos. I'm fine with closing this one.
Owner
There was a problem hiding this comment.
Agreed. I had missed that the iterable of the for loop had changed. Sorry!
Collaborator
Author
There was a problem hiding this comment.
No worries at all! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #737