Merged
Conversation
Owner
|
@xywei There are some CI failures here that I believe might be on the end of the new code. Could you take a look? |
inducer
reviewed
Oct 3, 2022
inducer
reviewed
Oct 20, 2022
Owner
inducer
left a comment
There was a problem hiding this comment.
Thanks for addressing the previous set of concerns. Looked again, found some more, including a potentially significant one about box number ordering.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Owner
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
inducer
reviewed
Oct 25, 2022
fa29266 to
db957d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of several PRs to refactor the tree build. This PR adds the very basic classes and methods to enable generation of uniform box mesh for
volumential(thus dropping its dependency on another custom fork ofboxtree).Generating a uniform mesh can be done as follows:
ListOfListBuilder: tolerateNonearguments pyopencl#600