Fix Video.toString() output illegal json and refactor#3032
Merged
iluwatar merged 1 commit intoiluwatar:masterfrom Oct 6, 2024
Merged
Fix Video.toString() output illegal json and refactor#3032iluwatar merged 1 commit intoiluwatar:masterfrom
iluwatar merged 1 commit intoiluwatar:masterfrom
Conversation
| Assertions.assertEquals(expectedDetails, actualFieldsDetails); | ||
| } | ||
|
|
||
| } No newline at end of file |
There was a problem hiding this comment.
Please add an extra line at EOF to satisfy github
refactor: json string concat add an extra line at EOF
|
Ritabrata1080
approved these changes
Sep 6, 2024
iluwatar
approved these changes
Oct 6, 2024
Owner
|
Looks good! Thank you for the contribution 🎉 |
Owner
|
@all-contributors please add @Xcyq for code |
Contributor
|
I've put up a pull request to add @Xcyq! 🎉 |
Owner
|
@all-contributors please add @Ritabrata1080 for review |
Contributor
|
I've put up a pull request to add @Ritabrata1080! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What problem does this PR solve?