Use native types when calling host functions#494
Merged
jprendes merged 3 commits intohyperlight-dev:mainfrom May 31, 2025
Merged
Use native types when calling host functions#494jprendes merged 3 commits intohyperlight-dev:mainfrom
jprendes merged 3 commits intohyperlight-dev:mainfrom
Conversation
jprendes
added
kind/enhancement
jprendes
force-pushed
the
call_fn
branch
3 times, most recently
from
b1bf92e to
d0ac424
Compare
jprendes
force-pushed
the
call_fn
branch
5 times, most recently
from
a8d93c6 to
613ef71
Compare
jprendes
requested review from
danbugs,
dblnz,
devigned,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
Contributor
Author
ludfjig
previously approved these changes
May 28, 2025
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
LGTM! Let's try to get one more person to review before we merge though
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
danbugs
added a commit
to danbugs/hyperlight
that referenced
this pull request
Jun 2, 2025
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
added a commit
to danbugs/hyperlight
that referenced
this pull request
Jun 2, 2025
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Closed
danbugs
added a commit
to danbugs/hyperlight
that referenced
this pull request
Jun 2, 2025
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
added a commit
to danbugs/hyperlight
that referenced
this pull request
Jun 2, 2025
Signed-off-by: danbugs <danilochiarlone@gmail.com>
danbugs
added a commit
to danbugs/hyperlight
that referenced
this pull request
Jun 2, 2025
Signed-off-by: danbugs <danilochiarlone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of
MultiUseSandbox::call_guest_function_by_nameandMultiUseGuestCallContext::callto use native Rust types instead of usingParamerValueandReturnValue.