Skip to content

Don't clone params on benchmark hotpath #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludfjig wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't clone params on benchmark hotpath #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/hyperlight_host/benches/benchmarks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,11 +379,10 @@ fn guest_call_benchmark_large_param(c: &mut Criterion) {
#[cfg(target_os = "windows")]
group.sample_size(10); // This benchmark is very slow on Windows, so we reduce the sample size to avoid long test runs.

// This benchmark includes time to first clone a vector and string, so it is not a "pure' benchmark of the guest call, but it's still useful
group.bench_function("guest_call_with_large_parameters", |b| {
const SIZE: usize = 50 * 1024 * 1024; // 50 MB
let large_vec = vec![0u8; SIZE];
let large_string = unsafe { String::from_utf8_unchecked(large_vec.clone()) }; // Safety: indeed above vec is valid utf8
let large_string = String::from_utf8(large_vec.clone()).unwrap();

let mut config = SandboxConfiguration::default();
config.set_input_data_size(2 * SIZE + (1024 * 1024)); // 2 * SIZE + 1 MB, to allow 1MB for the rest of the serialized function call
Expand All @@ -397,11 +396,14 @@ fn guest_call_benchmark_large_param(c: &mut Criterion) {
.unwrap();
let mut sandbox = sandbox.evolve().unwrap();

b.iter(|| {
sandbox
.call::<()>("LargeParameters", (large_vec.clone(), large_string.clone()))
.unwrap();
});
b.iter_with_setup(
|| (large_vec.clone(), large_string.clone()),
|(vec_clone, string_clone)| {
sandbox
.call::<()>("LargeParameters", (vec_clone, string_clone))
.unwrap()
},
);
});

group.finish();
Expand Down