Merged
Conversation
Contributor
marosset
commented
May 28, 2025
marosset
commented
- Installs just v1.40
- Installs rust v1.85.0
- We will still install rust v1.81.0 toolchain to address version skew issues between repos
Signed-off-by: Mark Rossett <marosset@microsoft.com>
Signed-off-by: Mark Rossett <marosset@microsoft.com>
There was a problem hiding this comment.
Pull Request Overview
Update the composite GitHub Action to use Rust 1.85.0 by default, bump the Just version, and install an older Rust 1.81.0 toolchain to mitigate version skew.
- Bump default
rust-toolchaininput from 1.74.0 to 1.85.0 - Update
just-versionfrom 1.27 to 1.40 - Add steps to install Rust 1.81.0 toolchain for both Linux and Windows runners
Comments suppressed due to low confidence (1)
action.yml:189
- [nitpick] Step names are inconsistent between the Linux and Windows blocks. Consider standardizing the naming (e.g., include the platform in both or neither) for clarity.
- name: Install older rust toolchain(s) (Windows)
jprendes
reviewed
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.