chore: Get executable name from the command#326
Merged
EnriqueL8 merged 1 commit intohyperledger:mainfrom Oct 3, 2024
Merged
Conversation
EnriqueL8
reviewed
Sep 12, 2024
Contributor
EnriqueL8
left a comment
There was a problem hiding this comment.
I think you are missing a few such as ff start message after an ff init
Signed-off-by: dwertent <david.wertenteil@kaleido.io>
EnriqueL8
reviewed
Sep 12, 2024
| // rootCmd represents the base command when called without any subcommands | ||
| var rootCmd = &cobra.Command{ | ||
| Use: "ff", | ||
| Use: ExecutableName, |
Contributor
There was a problem hiding this comment.
We really need to make this usage message better
Contributor
EnriqueL8
reviewed
Sep 12, 2024
Contributor
Author
|
I think the build failed due to a failure in the coverage report generation, maybe we should re-run the build job (it passed last time and the only change I made was the var name) |
Contributor
|
I reran it and it's still failing |
Contributor
|
I'm quite puzzled about why we are getting a broken pipe, might some related to etcd-io/etcd#17560 or the permission in the workflow |
Contributor
|
This is ready to go :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR enhances the FireFly CLI by making the executable name dynamic in the help messages. Instead of hardcoding the executable name, it is now loaded from the command-line arguments, allowing for dynamic help messages that reflect the actual executable name being used.
Before:
After: