[Fix]: Remove --platform flag from Docker commands in fabric_provider.go#323
Merged
EnriqueL8 merged 2 commits intohyperledger:mainfrom Aug 15, 2024
Merged
[Fix]: Remove --platform flag from Docker commands in fabric_provider.go#323EnriqueL8 merged 2 commits intohyperledger:mainfrom
EnriqueL8 merged 2 commits intohyperledger:mainfrom
Conversation
Signed-off-by: dwertent <david.wertenteil@kaleido.io>
EnriqueL8
reviewed
Aug 14, 2024
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Looks good - one suggestion would be to add a comment to the constants.go where the fabric images are set for the next person that updates them to check that they have ARM and AMD images
Signed-off-by: dwertent <david.wertenteil@kaleido.io>
EnriqueL8
approved these changes
Aug 14, 2024
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Great stuff - thanks for adding the format command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer needed since arm64 support was added in tag 2.5
Fixes #305