Skip to content

feat(service): expose Service and HttpService trait unconditionally#3591

Merged
seanmonstar merged 1 commit intohyperium:masterfrom
tottoto:service-trait
Apr 15, 2024
Merged

feat(service): expose Service and HttpService trait unconditionally#3591
seanmonstar merged 1 commit intohyperium:masterfrom
tottoto:service-trait

Conversation

@tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 2, 2024

Exposes Service and HttpService trait unconditionally.

refs: #3590

@dswij
Copy link
Member

dswij commented Mar 18, 2024

What's the benefit of having this without http1/http2?

@tottoto
Copy link
Contributor Author

tottoto commented Mar 18, 2024

I think it would be a benefit in the cases that crates which collaborate with hyper need to use service and do not themselves use the others in http1 or http2 features.

@seanmonstar seanmonstar merged commit 6aee2e6 into hyperium:master Apr 15, 2024
@tottoto tottoto deleted the service-trait branch April 15, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants