refactor: reduce noise in fmt::Debug outputs#855
Merged
seanmonstar merged 1 commit intomasterfrom Jul 30, 2025
Merged
Conversation
LucioFranco
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing some debugging again, and again reminded that some of these things just print way too much worthless noise. Such as:
(I indented that to help myself in this PR)
The most interesting changes here are that on the
Streamtype, many fields are only printed if they are in an interesting state. Such as if the boolean is true, or the option is Some. This does mean that if you care about the field always being there, this will be different. But I think it's a significant improvement.This is the revised output: