h2-support,h2-tests: add tools to ensure wake #794
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Aug 6, 2024
Merged
h2-support,h2-tests: add tools to ensure wake #794seanmonstar merged 1 commit intohyperium:masterfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
ajwerner
force-pushed
the
notify-testing
branch
from
e86bbaf to
a4468f0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ajwerner
force-pushed
the
notify-testing
branch
from
a4468f0 to
967246e
Compare
This commit adds wrappers around futures::future helpers and augments TestFuture to ensure that the underlying futures are notified before they are polled. This helps to catch bugs where there are missing notify calls or bad handling of the waker. The commit then extends the tests to use these helpers instead of the library functions from futures. It also ammends the client_requests::recv_too_big_headers test to no longer use the tokio spawned tasks that were added in hyperium#791.
ajwerner
force-pushed
the
notify-testing
branch
from
967246e to
f4afb84
Compare
Contributor
Author
|
Feel free to nitpick this, it was done hastily. |
seanmonstar
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds wrappers around futures::future helpers and augments
TestFuture to ensure that the underlying futures are notified before
they are polled. This helps to catch bugs where there are missing notify
calls or bad handling of the waker.
The commit then extends the tests to use these helpers instead of the
library functions from futures.
It also ammends the client_requests::recv_too_big_headers test to no
longer use the tokio spawned tasks that were added in #791.