xpu enablement on left cases #3654
Conversation
…d profiler example to xpu Signed-off-by: YAO Matrix <[email protected]>
Signed-off-by: YAO Matrix <[email protected]>
src/accelerate/launchers.py
Outdated
| To use this function absolutely zero calls to a CUDA device must be made in the notebook session before calling. If | ||
| any have been made, you will need to restart the notebook and make sure no cells use any CUDA capability. | ||
| To use this function absolutely zero calls to an accelerator must be made in the notebook session before calling. |
There was a problem hiding this comment.
NIT: I would maybe try to find better wording as accelerator - maybe device. Since the whole accelerate is built on top Accelerator class. If you had the same naming convention even before, we can keep it.
There was a problem hiding this comment.
@S1ro1 indeed, especially in context that the src code already uses Accelerator instance. Done, thx.
Signed-off-by: YAO Matrix <[email protected]>
S1ro1
left a comment
S1ro1
left a comment
There was a problem hiding this comment.
LGTM from me, let's wait for Marc, he should be back wednesday and can merge. Thank you!
|
@SunMarc , could you pls take a look? thx very much. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@bot /style |
|
Style bot fixed some files and pushed the changes. |
* 1. enable xpu for launcher 2. expand cuda only ds uts to xpu 3. expand profiler example to xpu Signed-off-by: YAO Matrix <[email protected]> * fix style Signed-off-by: YAO Matrix <[email protected]> * rename Signed-off-by: YAO Matrix <[email protected]> * Update profiler.py * Apply style fixes --------- Signed-off-by: YAO Matrix <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 participants
@SunMarc , pls help review, thx.