Conversation
Member
Author
|
Hey @NEKOYASAN Without this change, the client does not work well on rolldown-vite. What do you think of this? Can you review this? |
NEKOYASAN
approved these changes
Jan 2, 2026
Contributor
There was a problem hiding this comment.
I hadn't checked that thoroughly. Thank you.
My only concern is that the filter maybe will remain as is after the build, but I couldn't think of any other options...
Since it doesn't seem like these features will be included in rolldown, I think this is the best way to proceed.
rolldown/rolldown#3982 (comment)
Member
Author
Ah, I see... But, so, let's go with this. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Character classes (e.g.,
[a-zA-Z0-9-]) in glob patterns are not supported in rolldown-vite, which breaks the client.This change filters files with regex instead.