Bug: fix crud operation detection when using chain handlers#367
Merged
pmcnr-hx merged 1 commit intoholidayextras:masterfrom Jan 31, 2018
Merged
Conversation
slickmb
force-pushed
the
fix_chainhandler_crud_check
branch
from
7c82a05 to
5a0a922
Compare
Contributor
|
Thank you for the contribution. I should be able to review and merge it soon. |
Contributor
|
Just to inform, THanks |
Contributor
|
Your patch makes a lot a sense. Thanks for the contribution @slickmb. I shall merge and make a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: I ran into an issue where I had a ChainHandler pair with a store that did not support all the crud operations. I was expecting jsonapi to return a 403 action not supported error, but instead got a 500 when the chainHandler attempted to call the action on the underlying store (which failed with a null ref error).