Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Switch from rAF to setAnimationLoop#21

Merged
hmans merged 3 commits intomainfrom
set-animation-loop
Jan 18, 2021
Merged

Switch from rAF to setAnimationLoop#21
hmans merged 3 commits intomainfrom
set-animation-loop

Conversation

@hmans
Copy link
Copy Markdown
Owner

@hmans hmans commented Jan 18, 2021 •
edited
Loading

Changes the ticker from requestAnimationFrame to setAnimationLoop (see #18).

Checklist

  • Change the ticker to use setAnimationLoop
  • Add a VR example to /examples/
  • Figure out what else we need to add to make it work, like:
    • A boolean xr attribute on three-game that configures the renderer for VR
    • ...???

@hmans hmans marked this pull request as draft January 18, 2021 15:52
@hmans hmans marked this pull request as ready for review January 18, 2021 16:30
@hmans hmans merged commit a4714bf into main Jan 18, 2021
@hmans hmans deleted the set-animation-loop branch January 18, 2021 16:36
This was referenced Jan 19, 2021
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hmans