Fix ray #6564
Merged
Fix ray #6564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
This was referenced Feb 6, 2025
This was referenced Feb 13, 2025
This was referenced Feb 15, 2025
1587causalai
pushed a commit
to 1587causalai/llama_factory
that referenced
this pull request
Feb 18, 2025
This was referenced Feb 19, 2025
stephen-nju
pushed a commit
to stephen-nju/Llmtrain
that referenced
this pull request
Mar 24, 2025
Fix ray Former-commit-id: 6b34b69
yoonseok312
pushed a commit
to pensieve-ai/LLaMA-Factory-vlm
that referenced
this pull request
Apr 29, 2025
Fix ray Former-commit-id: 6b34b69
liu-qingyuan
pushed a commit
to liu-qingyuan/LLaMA-Factory-Megafake
that referenced
this pull request
Jun 6, 2025
Fix ray Former-commit-id: 6b34b69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix get_ray_args when args not a dict
Before submitting
when I train model not using a yaml or a json config,the args may not be a dict
so get_ray_args function may raise error
because allow_extral_key is valid only when args is a dictionary.