Skip to content

fix(lint): upgrade bare composition HTML to error#242

Merged
miguel-heygen merged 1 commit intomainfrom
lint/bare-composition-html
Apr 11, 2026
Merged

fix(lint): upgrade bare composition HTML to error#242
miguel-heygen merged 1 commit intomainfrom
lint/bare-composition-html

Conversation

@miguel-heygen
Copy link
Copy Markdown
Collaborator

@miguel-heygen miguel-heygen commented Apr 11, 2026 •
edited
Loading

Summary

  • Upgrades root_composition_missing_html_wrapper from warning to error — a bare <div data-composition-id> as index.html without <!DOCTYPE html>/<html>/<body> causes browsers to quirks-mode, the preview server to fail, and the bundler to silently skip runtime injection
  • Improves the error message to explain why this is bad, and includes a snippet of the offending root element
  • Skips <template>-wrapped compositions (already caught by the separate standalone_composition_wrapped_in_template rule)
  • Adds 8 tests covering the exact screenshot scenario, proper HTML, sub-compositions, plain HTML, and template wrappers

Test plan

  • All 441 existing tests pass (vitest run)
  • 8 new tests for root_composition_missing_html_wrapper and standalone_composition_wrapped_in_template
  • TypeScript build clean (tsc --noEmit)
  • oxlint + oxfmt pass
  • Run npx hyperframes lint on a bare composition index.html and verify it now reports an error

@miguel-heygen @claude
fix(lint): upgrade bare composition HTML rule to error severity
ac6dcc9 
A composition index.html that starts with a raw <div data-composition-id>
instead of <!DOCTYPE html><html> is a hard failure — browsers quirks-mode
it, the preview server cannot load it, and the bundler cannot inject
runtime scripts. Upgraded from warning to error with a clearer message.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@miguel-heygen miguel-heygen merged commit 794b021 into main Apr 11, 2026
21 checks passed
@miguel-heygen Graphite App
Copy link
Copy Markdown
Collaborator Author

miguel-heygen commented Apr 11, 2026

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrusso1020 jrusso1020 jrusso1020 approved these changes

@vanceingalls vanceingalls Awaiting requested review from vanceingalls

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miguel-heygen @jrusso1020