Skip to content

fix: address QA report P0-P2 issues for 10/10 agent experience#208

Merged
miguel-heygen merged 2 commits intomainfrom
fix/qa-report-improvements
Apr 6, 2026
Merged

fix: address QA report P0-P2 issues for 10/10 agent experience#208
miguel-heygen merged 2 commits intomainfrom
fix/qa-report-improvements

Conversation

@miguel-heygen
Copy link
Copy Markdown
Collaborator

@miguel-heygen miguel-heygen commented Apr 3, 2026

Summary

Addresses all 8 issues from the QA report to improve agent and user experience.

P0 — Must Fix

  • Blank template broken captions: Removed compositions/captions.html and its reference from the blank template. Every agent (10/10) hit 404 errors during render.
  • Inner-wrapper example: Added a clear structural comment in the blank template showing the correct class="clip" + inner wrapper pattern.
  • Sub-composition introspection: hyperframes compositions now reads external HTML files referenced via data-composition-src and shows their real duration/element count instead of 0.0s / 0 elements.

P1 — Fix Soon

  • Font mapping warnings: Now lists all mapped fonts, suggests alternatives (use a mapped font, add @font-face, install locally), and links to docs.
  • Browser 404s: Non-font "Failed to load resource" 404s now prefixed with [non-blocking] instead of [Browser:ERROR].
  • Render concurrency: Default workers increased from cores/2 (max 4) to cores*3/4 (max 6). Added --concurrency alias.

P2 — Nice to Have

  • Transform conflict fix suggestion: gsap_css_transform_conflict now suggests exact GSAP property replacements (e.g., xPercent: -50, yPercent: -50).
  • Upgrade --yes: Now actually runs the install instead of just printing the command.

Before / After

Font mapping warning

Before:

[Compiler] No deterministic font mapping for: DM Sans

After:

[Compiler] No deterministic font mapping for: DM Sans
  Mapped fonts: arial → inter, courier → jetbrains-mono, ...
  To fix, pick one:
    1. Use a mapped font name instead (see list above)
    2. Add a @font-face block in your HTML with a local or hosted font file
    3. Install the font locally on the render machine (Docker: add to Dockerfile)
    4. Add an alias to FONT_ALIASES in deterministicFonts.ts (for contributors)

Browser 404s during render

Before: [Browser:ERROR] Failed to load resource: the server responded with a status of 404
After: [non-blocking] Failed to load resource: the server responded with a status of 404

Transform conflict lint

Before: Fix: Remove the transform from CSS and use tl.fromTo...
After: Fix: Remove transform: translate(-50%, -50%) from CSS and replace with GSAP properties: xPercent: -50, yPercent: -50

Compositions command

Before:

overlay   0.0s   1920×1080   0 elements

After:

overlay   8.0s   1920×1080   2 elements ← compositions/overlay.html

Test plan

  • All 422 core tests pass
  • TypeScript compiles cleanly (all 4 packages)
  • Full monorepo build succeeds
  • hyperframes init --template blank ships without broken captions reference

@miguel-heygen miguel-heygen force-pushed the fix/qa-report-improvements branch from 22d97a6 to 3d1cc87 Compare April 3, 2026 12:33
@miguel-heygen miguel-heygen changed the base branch from main to refactor/replace-cheerio-with-linkedom April 3, 2026 12:34
P0: Remove broken captions sub-composition from blank template (caused
404s for 10/10 agents), add clear animation pattern comment showing
clip + inner wrapper structure, make compositions command introspect
sub-compositions via data-composition-src.

P1: Font mapping warnings now list all mapped fonts and suggest
alternatives (including local install), browser 404s prefixed with
[non-blocking] instead of [Browser:ERROR], default render concurrency
increased from cores/2 (max 4) to cores*3/4 (max 6) with --concurrency
alias.

P2: gsap_css_transform_conflict lint rule now suggests exact GSAP
property replacements (e.g. xPercent: -50), upgrade --yes actually
runs the install instead of just printing the command.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@miguel-heygen miguel-heygen force-pushed the fix/qa-report-improvements branch from 3d1cc87 to c3bd8b7 Compare April 3, 2026 12:41
@miguel-heygen miguel-heygen changed the base branch from refactor/replace-cheerio-with-linkedom to main April 3, 2026 12:41
Copy link
Copy Markdown
Collaborator Author

miguel-heygen commented Apr 3, 2026

- Remove --concurrency alias — --workers is the only flag
- Remove the 1-8 worker cap — let users set any positive number,
  the engine's parallelCoordinator handles CPU/memory scaling
- Keep the auto default (3/4 of cores, max 6)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@miguel-heygen miguel-heygen force-pushed the fix/qa-report-improvements branch from c7ca658 to 645f89f Compare April 3, 2026 14:52
@miguel-heygen miguel-heygen merged commit baa3d81 into main Apr 6, 2026
22 checks passed
Copy link
Copy Markdown
Collaborator Author

Merge activity

@miguel-heygen miguel-heygen deleted the fix/qa-report-improvements branch April 6, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants