Conversation
dnephin
force-pushed
the
go1.13-errors-compat
branch
from
07d9576 to
96a78fc
Compare
mitchellh
approved these changes
Jul 13, 2020
Contributor
Author
|
Thank you! |
This was referenced Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit adds an
Unwrapto the error type, so that errors created byerrwrapcan be unwrapped byerrors.Isanderrors.As.The second commit adds another case to
Walk(which is used by Get/GetAll/Contains/etc) to support the go1.13 wrap interface. This should allow existing packages to start usingfmt.Errorfto wrap errors without having to change everyerrwrapcall in a project.