VAULT-41529: fix filtering by variant and no scenario name#168
Merged
ryancragun merged 7 commits intomainfrom Dec 19, 2025
Merged
VAULT-41529: fix filtering by variant and no scenario name#168ryancragun merged 7 commits intomainfrom
ryancragun merged 7 commits intomainfrom
Conversation
When we rewrote scenario filtering to be a decode time operation we missed a case that resulted in broken filtering. If we gave a list of variants but did not include a scenario name the list would return scenarnios with matching variants but would also include the scenario name of scenarios that either didn't have a matrix defined or had no matrix variants that matched. Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
… match Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
raskchanky
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to read this pull request
When we rewrote scenario filtering to be a decode time operation we missed a case that resulted in broken filtering. If we given a filter that includes variants but does not include a scenario name the list would return scenarios with matching variants but would also include the scenario name of scenarios that either didn't have a matrix defined or had no matrix variants that matched. This fixes it to exclude scenario blocks that have no matching variants when given such filters.
Before
> enos scenario list arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms NAME VARIANTS agent arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms autopilot arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms benchmark cloud dev_pr_replication dev_single_cluster dr_replication pr_replication proxy arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms seal_ha smoke arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms ui arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms upgrade arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskmsAfter
> enos scenario list arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms NAME VARIANTS agent arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms autopilot arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms proxy arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms smoke arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms ui arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskms upgrade arch:arm64 artifact_source:crt artifact_type:bundle backend:raft config_mode:file consul_edition:ce consul_version:1.18.2 distro:sles edition:ent ip_version:6 seal:awskmsChecklist