fix: prevent arm64 OOM during linking with lld + job limit#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lldas the linker for Linux targets in.cargo/config.toml— lld uses ~3x less memory than the defaultldlinker, which is critical for the arm64 Graviton runner (c7g.2xlarge, 16GB RAM)clangto apt-get install (required as the linker driver for-fuse-ld=lld)CARGO_BUILD_JOBS=4in both Dockerfiles to cap parallel compilation and further reduce peak memoryRoot cause
The arm64 Docker build OOMs during the final link step (
collect2: fatal error: ld terminated with signal 9 [Killed]). The default GNUldlinker loads all object files into memory at once and on arm64 with hundreds of crates this exceeds 16GB. The amd64 build succeeds because the DOKS runner pod has more available memory.Changes
.cargo/config.toml[target.x86_64-unknown-linux-gnu]and[target.aarch64-unknown-linux-gnu]sections using clang+llddocker/Dockerfileclangto build deps, addENV CARGO_BUILD_JOBS=4.github/Dockerfileclangto build deps, addENV CARGO_BUILD_JOBS=4Test plan