Prefer @llvm.ceil.* intrinsics #8897
Merged
+4
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm/llvm-project#171288 removed the SDAG lowering for ceil/ceilf calls. This was causing some errors for us when using webassembly: Internal Error at third_party/halide/halide/src/WasmExecutor.cpp:2368 Condition failed: instance: Error initializing module: invalid import "env.ceilf" Explicitly using the intrinsics is still covered by webassembly and given the commenting out of these intrinsics mentions that they were not used due to needing to support LLVM <3.3, I think we can safely enable these now.
alexreinking
approved these changes
Dec 11, 2025
Member
|
Failures were unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#171288 removed the SDAG lowering for ceil/ceilf calls. This was causing some errors for us when using webassembly:
Internal Error at third_party/halide/halide/src/WasmExecutor.cpp:2368 Condition failed: instance: Error initializing module: invalid import "env.ceilf"
Explicitly using the intrinsics is still covered by webassembly and given the commenting out of these intrinsics mentions that they were not used due to needing to support LLVM <3.3, I think we can safely enable these now.