Fix for the removed DataLayout constructor. #8391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the fix, but this needs to be conditionalized for multiple versions of LLVM. I'll upload a patch. |
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
LGTM pending green
steven-johnson
approved these changes
Aug 13, 2024
Contributor
Author
|
No it doesn't, afaik. The |
Member
I agree it's better to avoid |
alexreinking
approved these changes
Aug 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the latest change in LLVM where the
DataLayoutconstructor that accepts aModuleis removed. llvm/llvm-project@75c7bcaCC @steven-johnson