Use python itself to get the extension suffix, not python-config #8148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
approved these changes
Mar 11, 2024
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
Please add the PR explanation as a comment
Member
Author
|
Done. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the buildbots has gotten itself into a weird state where python-config is from python 3.12, but the python used in the venv is python 3.11, so the extension suffix on the python module in the onnx app is wrong.
virtual envs don't seem to include python-config, so rather than mess with the system this PR just changes the makefile to get the extension suffix from python itself.