Skip to content

Conversation

@rootjalex
Copy link
Member

The bounds visitor on a let should use unique_name() for the introduced variables. Without this change, Halide sometimes internally generates expressions of the form (let x = (let x = ... in ...) in ...) which can cause failures when substituting in lets and simplifying.

@rootjalex rootjalex assigned abadams and unassigned abadams Jan 26, 2022
@rootjalex rootjalex requested a review from abadams January 26, 2022 15:20
@rootjalex rootjalex merged commit 3e6d43b into master Jan 26, 2022
@rootjalex rootjalex deleted the rootjalex/let_bounds_fix branch January 26, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants