Merged
Conversation
tilacog
force-pushed
the
tiago/migrate-spec-version-0-0-4
branch
from
97c9b0f to
0647be2
Compare
tilacog
force-pushed
the
tiago/migrate-spec-version-0-0-4
branch
from
0647be2 to
b4c6e29
Compare
3 tasks
evaporei
approved these changes
Mar 30, 2022
tilacog
force-pushed
the
tiago/migrate-spec-version-0-0-4
branch
2 times, most recently
from
7d67801 to
c26f150
Compare
Contributor
Author
|
Fixed rebase conlflicts. |
Contributor
|
@tilacog You can do a |
tilacog
force-pushed
the
tiago/migrate-spec-version-0-0-4
branch
from
c26f150 to
84c8f8b
Compare
adairrr
pushed a commit
to adairrr/terra-graph-cli
that referenced
this pull request
May 5, 2022
Migrations for `specVersion 0.0.4` can be found in PR graphprotocol#724 graphprotocol#724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a migration for upgrading
specVersion0.0.2 (and the non-canonical 0.0.3) to 0.0.4.This new specification version enforces that all used features must be listed in the
featureskey of the subgraph's manifest.Since feature detection and validation occur inside a
graph-nodeinstance during deploy time, subgraphs that use any feature are expected to end with an invalidsubgraph.yml, asgraph-cliwon't be able to infer and fill thefeaturessection of the manifest file automatically.