feat(node): use latest version of node-gyp, see #2#3
Open
sibelius wants to merge 5 commits intograndchef:mainfrom
Open
feat(node): use latest version of node-gyp, see #2#3sibelius wants to merge 5 commits intograndchef:mainfrom
sibelius wants to merge 5 commits intograndchef:mainfrom
Conversation
|
@sibelius apply patch are failing |
Author
|
we need to apply to the new node-abi version |
Author
|
fixed the patch |
Author
|
what about building only for lts targets? or latest version of all these packages? |
|
the lib need to support at least node 16 and electron 18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-std=c++17to build on latest version of node and electron