Open
Conversation
Contributor
lanrat
commented
Apr 26, 2021
- typos
- lint warnings
- error checking
- use go naming conventions for internal types
- Fixes server.Shutdown() should print errors #72
Owner
|
Thanks for your contribution. |
Contributor
Author
|
Thanks for checking out this PR. The Windows test that is failing is below: $ go test --parallel=1
go: finding github.com/pkg/errors v0.9.1
2021/04/26 18:25:21 [zeroconf] no suitable IPv4 interface: not implemented on windows/amd64
2021/04/26 18:25:21 [zeroconf] no suitable IPv6 interface: not implemented on windows/amd64
panic: while registering mdns service: no supported interface
goroutine 8 [running]:
github.com/grandcat/zeroconf.startMDNS(0x680e00, 0xc0000461e0, 0x22b8, 0x6465a8, 0x12, 0x6455a7, 0x10, 0x642786, 0x6)
C:/Users/travis/gopath/src/github.com/grandcat/zeroconf/service_test.go:25 +0x323
created by github.com/grandcat/zeroconf.TestBasic
C:/Users/travis/gopath/src/github.com/grandcat/zeroconf/service_test.go:43 +0x123
exit status 2
FAIL github.com/grandcat/zeroconf 0.080s
The command "go test --parallel=1" exited with 1.The test is failing for Windows in this PR because of the additional error checking. Previously the test would fail silently because the errors were not checked. The reason for the failure was not introduced in this PR, it was just made visible. The test can be updated to ignore the error on Windows, or fixed to better support Windows. Both were initially out of scope for this PR. @grandcat what are your thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.