feat: Introduce shardable probabilistic topk for instant queries. (backport k227)#14765
Merged
feat: Introduce shardable probabilistic topk for instant queries. (backport k227)#14765
Conversation
cstyan
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 7b53f20 from #14243
What this PR does / why we need it:
This change introduces a very simplified shardable topk approximation through the new vector aggregation
approx_topk.We use a count min sketch and track all labels not just the top
k. Since this list can grow quite large the feature is only supported for instant queries. Grouping is also not supported and should be handled by an innersum byorsum withouteven though this might not be the same behaviour astopk by.The sharding works by turning the
approx_topk(k, inner)query into the following expression:__count_min_sketch__is calculated for each shard and merge on the frontend.eval_cmsiterates through the labels list and determines the count for each.topkselects then the top items.The number of labels tracked on the querier side when evaluating
__count_min_sketch__is limited by the heap. It does count all values but the ke-value pairs might not be known.Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR