Retry Spock methods with custom @Unroll template
#275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavlo Shevchenko <[email protected]>
Signed-off-by: Pavlo Shevchenko <[email protected]>
pshevche
force-pushed
the
pshevche/94-retry-unroll-junit4
branch
from
524567d to
885ca22
Compare
jean-andre-gauthier
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spock methods with a custom
@Unrolltemplate failed to be retried, as we did not search for a method corresponding to the reported test name. With this change, we check the method for the presence of@Unrollannotation. If the reported test name matches the declared template, we will add the declared test method name to the retry filter instead of the reported name.Note: this wasn't working neither for Spock 2 nor for Spock 1 with JUnit platform or not.