This repository was archived by the owner on Jan 17, 2024. It is now read-only.
Remove double network for side containers#45
Merged
raydouglass merged 1 commit intogpuopenanalytics:masterfrom Nov 20, 2020
Merged
Remove double network for side containers#45raydouglass merged 1 commit intogpuopenanalytics:masterfrom
raydouglass merged 1 commit intogpuopenanalytics:masterfrom
Conversation
1) Use the DockerNetwork if it exists, otherwise use the bridge network 2) Explicitly create a DockerNetwork with the bridge driver
dillon-cullinan
approved these changes
Nov 20, 2020
ajschmidt8
approved these changes
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45