Skip to content
This repository was archived by the owner on Jan 17, 2024. It is now read-only.

[REVIEW] Pipeline support#15

Merged
raydouglass merged 12 commits intogpuopenanalytics:masterfrom
raydouglass:pipeline-support
Feb 18, 2020
Merged

[REVIEW] Pipeline support#15
raydouglass merged 12 commits intogpuopenanalytics:masterfrom
raydouglass:pipeline-support

Conversation

@raydouglass
Copy link
Copy Markdown
Contributor

@raydouglass raydouglass commented Oct 9, 2019 •
edited
Loading

Fixes #11

This is a large refactor to add in support for Jenkins pipelines.

The format is roughly:

withRemoteDocker(debug: 'true', 
    main: image(image: 'gpuci/rapidsai-base:cuda10.1-ubuntu16.04-gcc5-py3.6',
        forcePull: 'true',
        configItemList: [cudaVersion('10.1'),
            runtime(dockerRuntime: 'nvidia'), 
            gpus(nvidiaDevices: 'executor')
        ],
        volumes: [volume(hostPath: '/tmp', destPath: "${WORKSPACE}/tmp", readOnly: 'false')]
        )
) {
    ...
}

The main changes were refactors to DockerLauncher so it wasn't heavily tied to an AbstractBuild (which isn't present in a WorkflowJob).

To-do:

  • JavaDocs
  • Pipeline Snippets
  • Exeception handling cleanup
  • Code duplication cleanup

@raydouglass
FEA Initial pipeline support
e655ac5 
Support is very basic, just specifiying an image.

There is a lot of duplicated code between DockerLauncher,
AbstractDockerLauncher, and DockerLauncherDecorator.

RemoteDockerBuildWrapper is broken, so non-pipeline builds do not work.
@raydouglass
Refactor container launching
6a43358
@raydouglass
Adds symbols for configurations
2654f7b
@raydouglass
Add environment
b5142ea
@raydouglass
Remove test case
37f6015
@raydouglass raydouglass added the 2 - In Progress Currenty a work in progress label Oct 9, 2019
@raydouglass raydouglass self-assigned this Oct 9, 2019
@raydouglass raydouglass changed the title [WIP] Pipeline support [REVIEW] Pipeline support Oct 11, 2019
mike-wendt
mike-wendt reviewed Dec 5, 2019
View reviewed changes
Comment thread src/main/java/com/gpuopenanalytics/jenkins/remotedocker/config/CudaVersionConfigItem.java
"9.2",
"10.0");
"10.0",
"10.1");
Copy link
Copy Markdown

@mike-wendt mike-wendt Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI 10.2 is released

mike-wendt
mike-wendt approved these changes Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown

@mike-wendt mike-wendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpuopenanalytics gpuopenanalytics deleted a comment from mike-wendt Dec 17, 2019
@raydouglass raydouglass merged commit df517d5 into gpuopenanalytics:master Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mike-wendt mike-wendt mike-wendt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@raydouglass raydouglass

Labels

2 - In Progress Currenty a work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA] Add support for Jenkins pipelines

2 participants

@raydouglass @mike-wendt