Implement generic Table for basic CRUD operations - Save multiple#33
Merged
VojtechVitek merged 3 commits intotable_generics_lock_for_updatefrom Oct 24, 2025
Merged
Implement generic Table for basic CRUD operations - Save multiple#33VojtechVitek merged 3 commits intotable_generics_lock_for_updatefrom
VojtechVitek merged 3 commits intotable_generics_lock_for_updatefrom
Conversation
Member
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
Minor feedback / questions. Thank you. I think this is very decent already. 👍
| end := start + chunkSize | ||
| if end > len(insertRecords) { | ||
| end = len(insertRecords) | ||
| } |
Member
There was a problem hiding this comment.
What if you chose only one of the two insertRecords vs. insertIndices. Why do we need both?
Member
Author
There was a problem hiding this comment.
I need to update records in passed slice, and since I am chunking the requests, I am iterating over different slice.
Comment on lines
+132
to
+135
| // update original slice | ||
| for i, rr := range chunk { | ||
| records[insertIndices[start+i]] = rr | ||
| } |
Member
There was a problem hiding this comment.
I'm not following 100% why this is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save multiple implementation.