Add build with docker docs #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eternal-flame-AD
left a comment
eternal-flame-AD
left a comment
There was a problem hiding this comment.
Great work! I have tried it would on linux/amd64 and the resulting binary works on my machine.
jmattheis
force-pushed
the
gotify/build-with-docker
branch
from
c2556b7 to
bbef6f6
Compare
Member
|
It's mostly OK. I recommend we wait for go 1.12 which should be released this weekend and use that for the next release. |
Member
Author
|
Alright. |
13 tasks
jmattheis
force-pushed
the
gotify/build-with-docker
branch
from
bbef6f6 to
1a510d6
Compare
eternal-flame-AD
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.