issues/158/examples for working api with javascript frontend#162
Merged
coreydaley merged 10 commits intogorilla:mainfrom Aug 17, 2023
francoposa:issues/158/examples-for-working-api-with-javascript-frontend
Merged
issues/158/examples for working api with javascript frontend#162coreydaley merged 10 commits intogorilla:mainfrom francoposa:issues/158/examples-for-working-api-with-javascript-frontend
coreydaley merged 10 commits intogorilla:mainfrom
francoposa:issues/158/examples-for-working-api-with-javascript-frontend
Conversation
robbat2
reviewed
Mar 29, 2022
Contributor
Author
|
@DavidLarsKetch do you have any input on how to approach the README? |
|
Would you mind updating your example to use go1.20 and update the dependencies in your go.mod? Then I think we can get this merged. |
coreydaley
previously approved these changes
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 5 5
Lines 353 353
=======================================
Hits 321 321
Misses 25 25
Partials 7 7 |
|
Hi @francoposa
Could you point me to a resource about this? Is CORS a pre-requisite for CSRF protection? If I setup gorilla/csrf on my SPA without CORS, will my site still be vulnerable to CSRF? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158, which is essentially that
Summary of Changes
I have merged/copied over these simplified examples from my own repository of working examples.
I was not sure how the maintainers may want to reference these examples in the main README. Copying them over to the README verbatim would be putting a lot of code into the README, but without changing the current README, the content there differs significantly from the examples.